fix: ignore nested dependency trees in watcher - #4
Open
kvoon3 wants to merge 1 commit into
Open
Conversation
|
+1 |
kvoon3
force-pushed
the
fix/nested-watch-directories
branch
from
July 29, 2026 09:56
dbf969d to
4ec8c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Summary
Prevent
/diff-reviewfrom crashing Pi when reviewing repositories that contain nestednode_modulesor.gitdirectories.
Problem
The file watcher only ignored
.gitandnode_moduleswhen they were located directly under the repository root.In repositories containing nested dependency trees or embedded Git repositories, Chokidar could create too many file
watchers and eventually emit:
Because the watcher error was unhandled, the error terminated Pi.
Changes